[Re-devel] Adding video to an established audio call - for

Gary Metalle gary.metalle at rvl.co.uk
Tue Jan 3 10:03:18 CET 2017


Hi

 

If you’ve made modifications to the code then I won’t be much help sorry.  Yes the update_media function will be called when baresip receives the re-invite message from the remote caller. I’m not sure about sending the re-invite from the baresip side of the call but in theory it should be the same. I don’t see how you can avoid calling the ‘video_start’ function anyway though regardless of who sends the re-invite.

 

Gary

 

From: usha aradhya [mailto:usha.aradhya7101 at gmail.com] 
Sent: 03 January 2017 08:41
To: Gary Metalle
Cc: re-devel at lists.creytiv.com
Subject: Re: [Re-devel] Adding video to an established audio call - for

 

Hi Gary,

 

Sorry to ask you in detail again you mean update_media function.  What i see the caller of this function is mostly while we are answering or receving re-invite. 

 

1. I want to trigger a audio call from baresip to SIP phone and then attach video for the same call from baresip (by sending re-invite (video upgrade request) from baresip to sip phone). 

 

when i trigger a audio call i would have not allocated for  " call->video " based on vidmode flag hence directly using this fix would result in segfault. 

 

On Tue, Jan 3, 2017 at 1:47 PM, Gary Metalle <gary.metalle at rvl.co.uk> wrote:

Hiya

 

It’s not much to change and is restricted to call.c. Here’s the patch that should include what you need:

 

--- call.c                2016-07-22 20:17:45.000000000 +0100

 

+++ call_new.c  2016-12-07 09:03:20.427197844 +0000

 

@@ -318,10 +318,13 @@

 

sc->pt, sc->params);

 

                               if (err) {

 

                                               warning("call: video stream error: %m\n", err);

 

+                             } else {

 

+                                             err =

video_start(call->video, call->peer_uri);

 

                               }

 

               }

 

               else if (call->video) {

 

                               info("video stream is disabled..\n");

 

+                             video_stop(call->video);

 

               }

 

#endif

 

 

From: usha aradhya [mailto:usha.aradhya7101 at gmail.com] 
Sent: 03 January 2017 08:15
To: Gary Metalle
Cc: re-devel at lists.creytiv.com
Subject: Re: [Re-devel] Adding video to an established audio call - for

 

Hi Gary,

 

Thanks , have done lot of modification on 0.4 version of baresip for suiting my application. Hence it would be helpful if you share details of files to merge from 0.5. for this issue.

 

 

On 03-Jan-2017 1:41 PM, "Gary Metalle" <gary.metalle at rvl.co.uk> wrote:

Hi Usha

If you use the latest version of Baresip (0.5.0) that Alfred has just
released then this will now work ok. I've tested it using Linphone and
Bria Softphone clients but making an audio-only call to start with and
then adding video afterwards.

Gary

-----Original Message-----
From: Re-devel [mailto:re-devel-bounces at lists.creytiv.com] On Behalf Of
re-devel-request at lists.creytiv.com
Sent: 29 December 2016 11:00
To: re-devel at lists.creytiv.com
Subject: Re-devel Digest, Vol 38, Issue 7

Send Re-devel mailing list submissions to
        re-devel at lists.creytiv.com

To subscribe or unsubscribe via the World Wide Web, visit
        http://lists.creytiv.com/mailman/listinfo/re-devel
or, via email, send a message with subject or body 'help' to
        re-devel-request at lists.creytiv.com

You can reach the person managing the list at
        re-devel-owner at lists.creytiv.com

When replying, please edit your Subject line so it is more specific than
"Re: Contents of Re-devel digest..."


Today's Topics:

   1. 488 Not Acceptable Here due to 101 telephone-event        received
      (usha aradhya)
   2. Adding video to an established audio call - for   originating
      call (usha aradhya)


----------------------------------------------------------------------

Message: 1
Date: Thu, 29 Dec 2016 14:19:45 +0530
From: usha aradhya <usha.aradhya7101 at gmail.com>
To: re-devel at lists.creytiv.com
Subject: [Re-devel] 488 Not Acceptable Here due to 101 telephone-event
        received
Message-ID:

<CAPzhiZAJt0FyLX9hYyp-rOgsFQJW8jJOdTyC7ZT-7MbROEyi6g at mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

Hi

I encountered 488 not acceptable here when i receive 101 telephone-event
first in sdp. I added a fix for it by ignoring dat in sdp_media_format
function (invoked by have_common_audio_codecs)

if (fmt && !str_casecmp(fmt->name, "telephone-event"))
                {
                     printf("\n Entered telephone-event inside
sdp_media_rformat\n");
                     continue;
                }
 inside for loop so that i continue to find any other common codec. Is
there a proper fix for this ?

Thanks
Usha Aradhya
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.creytiv.com/pipermail/re-devel/attachments/20161229/8a7842
90/attachment-0001.html <http://lists.creytiv.com/pipermail/re-devel/attachments/20161229/8a784290/attachment-0001.html> >

------------------------------

Message: 2
Date: Thu, 29 Dec 2016 14:51:38 +0530
From: usha aradhya <usha.aradhya7101 at gmail.com>
To: re-devel at lists.creytiv.com
Subject: [Re-devel] Adding video to an established audio call - for
        originating call
Message-ID:

<CAPzhiZDehuJ4mB5m6=8xMjYn8KRHCwpgPRuwu+h+AFFngZtchQ at mail.gmail.com <mailto:8xMjYn8KRHCwpgPRuwu%2Bh%2BAFFngZtchQ at mail.gmail.com> >
Content-Type: text/plain; charset="utf-8"

Hi

I want a trigger a scenario where

1 . Audio call is established from UA1 (originating call from UA1) to
SIP phone.
2. Want to add a video to the same call from UA1 to SIP phone.

Thanks & Regards,
Usha Aradhya
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.creytiv.com/pipermail/re-devel/attachments/20161229/d38bfd
93/attachment-0001.html <http://lists.creytiv.com/pipermail/re-devel/attachments/20161229/d38bfd93/attachment-0001.html> >

------------------------------

Subject: Digest Footer

_______________________________________________
Re-devel mailing list
Re-devel at lists.creytiv.com
http://lists.creytiv.com/mailman/listinfo/re-devel


------------------------------

End of Re-devel Digest, Vol 38, Issue 7
***************************************

_______________________________________________
Re-devel mailing list
Re-devel at lists.creytiv.com
http://lists.creytiv.com/mailman/listinfo/re-devel

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.creytiv.com/pipermail/re-devel/attachments/20170103/ddf78977/attachment.html>
-------------- next part --------------
_______________________________________________
Re-devel mailing list
Re-devel at lists.creytiv.com
http://lists.creytiv.com/mailman/listinfo/re-devel


More information about the Re-devel mailing list